MoonsideGames
/
Refresh
1
0
Fork 1
Code Issues 1 Pull Requests 2 Projects Releases 33 Wiki Activity

Descriptor validation fix #32

Merged
cosmonaut merged 2 commits from descriptor_cache_fix into main 2023-01-11 02:41:33 +00:00
Conversation 0 Commits 2 Files Changed 1
cosmonaut commented 2023-01-11 02:39:31 +00:00
Owner

The validator layer was complaining about us updating bound descriptor sets, this is technically a bug in the validator layer but resetting the command buffer in Cleanup makes more sense anyway. Also changed the wait for timeout call to a fence status query to make it easier to understand.

The validator layer was complaining about us updating bound descriptor sets, this is technically a bug in the validator layer but resetting the command buffer in Cleanup makes more sense anyway. Also changed the wait for timeout call to a fence status query to make it easier to understand.
cosmonaut added 2 commits 2023-01-11 02:39:33 +00:00
continuous-integration/drone/push Build is passing Details
c0c6d2f9fd change vkWaitForFences call to vkGetFenceStatus
continuous-integration/drone/push Build is passing Details
continuous-integration/drone/pr Build is passing Details
8edab57f7b move reset calls to Clean instead of Acquire
cosmonaut merged commit 903192cb4c into main 2023-01-11 02:41:33 +00:00
cosmonaut deleted branch descriptor_cache_fix 2023-01-11 02:41:33 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: MoonsideGames/Refresh#32
There is no content yet.
Delete Branch "descriptor_cache_fix"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?