MoonsideGames
/
Refresh
1
0
Fork 1
Code Issues 1 Pull Requests 2 Projects Releases 33 Wiki Activity

update documentation + remove validation + misc cleanup #29

Closed
TheSpydog wants to merge 1 commits from TheSpydog/Refresh:docs-and-cleanup into main
pull from: TheSpydog/Refresh:docs-and-cleanup
merge into: MoonsideGames:main
Conversation 1 Commits 1 Files Changed 2
TheSpydog commented 2022-12-29 01:57:39 +00:00
  • Updated the documentation for Refresh_SetTextureData to warn that the data copy may not happen at the expected execution time.
  • Updated the documentation for Refresh_BindVertexBuffers to mention it should only be called after binding a graphics pipeline.
  • Removed all remaining validation checks. Validation will be handled in MoonWorks instead.
  • Removed an unused struct from Refresh.h -- I think it predates a refactor of compute pipelines.
  • Removed an unused parameter from VULKAN_INTERNAL_CreateUniformBuffer.
* Updated the documentation for Refresh_SetTextureData to warn that the data copy may not happen at the expected execution time. * Updated the documentation for Refresh_BindVertexBuffers to mention it should only be called after binding a graphics pipeline. * Removed all remaining validation checks. Validation will be handled in MoonWorks instead. * Removed an unused struct from Refresh.h -- I think it predates a refactor of compute pipelines. * Removed an unused parameter from VULKAN_INTERNAL_CreateUniformBuffer.
TheSpydog added 1 commit 2022-12-29 01:57:41 +00:00
continuous-integration/drone/pr Build is passing Details
c0624a9e28 update documentation + remove validation + misc cleanup
cosmonaut commented 2022-12-29 03:08:45 +00:00
Owner

Merged: 15b35fccfe

Merged: https://gitea.moonside.games/MoonsideGames/Refresh/commit/15b35fccfeb9f0bac0bd119420dfcc5a4b47d15e
cosmonaut closed this pull request 2022-12-29 03:08:45 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: MoonsideGames/Refresh#29
There is no content yet.
Delete Branch "TheSpydog/Refresh:docs-and-cleanup"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?