trying to do tiled draws

Data/AtlasAnimation.cs

@@ -1,14 +0,0 @@
-namespace Kav
-{
-    public struct AtlasAnimation
-    {
-        public UVData[] Frames { get; }
-        public int Framerate { get; }
-
-        public AtlasAnimation(UVData[] frames, int framerate)
-        {
-            Frames = frames;
-            Framerate = framerate;
-        }
-    }
-}

Data/InstanceData.cs

@@ -1,63 +0,0 @@
-using System.Collections.Generic;
-using Microsoft.Xna.Framework.Graphics;
-
-namespace Kav
-{
-    public class InstanceData<T> where T : struct, IVertexType
-    {
-        public T[] InstanceDataArray { get; }
-        public DynamicVertexBuffer VertexBuffer { get; }
-        public int InstanceCount { get; private set; }
-
-        public InstanceData(GraphicsDevice graphicsDevice, int size)
-        {
-            InstanceDataArray = new T[size];
-
-            VertexBuffer = new DynamicVertexBuffer(
-                graphicsDevice,
-                typeof(T),
-                size,
-                BufferUsage.WriteOnly
-            );
-
-            InstanceCount = 0;
-        }
-
-        public void AddAndSetData(IEnumerable<T> data)
-        {
-            InstanceCount = 0;
-            foreach (var datum in data)
-            {
-                AddData(datum);
-            }
-
-            if (InstanceCount == 0) { throw new System.Exception(); }
-
-            SetData();
-        }
-
-        public void AddData(T datum)
-        {
-            InstanceDataArray[InstanceCount] = datum;
-            InstanceCount += 1;
-        }
-
-        public void SetData()
-        {
-            if (InstanceCount > 0)
-            {
-                VertexBuffer.SetData(
-                    InstanceDataArray,
-                    0,
-                    InstanceCount,
-                    SetDataOptions.NoOverwrite
-                );
-            }
-        }
-
-        public void Clear()
-        {
-            InstanceCount = 0;
-        }
-    }
-}

Data/MeshPartDrawData.cs

@@ -0,0 +1,35 @@
+using Microsoft.Xna.Framework;
+using Microsoft.Xna.Framework.Graphics;
+
+namespace Kav.Data
+{
+    public struct MeshPartDrawData : IGBufferDrawable, IUVDrawable, ICullable, IIndexDrawable
+    {
+        public MeshPart MeshPart { get; }
+        public Matrix TransformMatrix { get; }
+        public UVData UVData { get; }
+
+        public BoundingBox BoundingBox => MeshPart.BoundingBox;
+
+        public IndexBuffer IndexBuffer => MeshPart.IndexBuffer;
+        public VertexBuffer VertexBuffer => MeshPart.VertexBuffer;
+
+        public Vector3 Albedo => MeshPart.Albedo;
+        public float Metallic => MeshPart.Metallic;
+        public float Roughness => MeshPart.Roughness;
+
+        public Texture2D AlbedoTexture => MeshPart.AlbedoTexture;
+        public Texture2D NormalTexture => MeshPart.NormalTexture;
+        public Texture2D MetallicRoughnessTexture => MeshPart.MetallicRoughnessTexture;
+
+        public MeshPartDrawData(
+            MeshPart meshPart,
+            Matrix transformMatrix,
+            UVData uvData
+        ) {
+            MeshPart = meshPart;
+            TransformMatrix = transformMatrix;
+            UVData = uvData;
+        }
+    }
+}

Data/MeshSpriteDrawData.cs

@@ -1,35 +1,26 @@
 using Microsoft.Xna.Framework;
-using Microsoft.Xna.Framework.Graphics;
 
 namespace Kav.Data
 {
-    public struct MeshSpriteDrawData : IIndexDrawable, ICullable, ITransformable
+    public struct MeshSpriteDrawData : ICullable
     {
-        public SpriteMesh MeshSprite { get; }
-        public Texture2D Texture { get; }
-        public Texture2D Normal { get; }
+        public MeshSprite MeshSprite { get; }
         public SpriteBillboardConstraint BillboardConstraint { get; }
         public Matrix TransformMatrix { get; }
-        public UVData UVOffset { get; }
+        public UVData UVData { get; }
 
-        public IndexBuffer IndexBuffer => MeshSprite.IndexBuffer;
-        public VertexBuffer VertexBuffer => MeshSprite.VertexBuffer;
         public BoundingBox BoundingBox => MeshSprite.BoundingBox;
 
         public MeshSpriteDrawData(
-            SpriteMesh meshSprite,
-            Texture2D texture,
-            Texture2D normal,
+            MeshSprite meshSprite,
             SpriteBillboardConstraint billboardConstraint,
             Matrix transformMatrix,
-            UVData offset
+            UVData uvData
         ) {
             MeshSprite = meshSprite;
-            Texture = texture;
-            Normal = normal;
             BillboardConstraint = billboardConstraint;
             TransformMatrix = transformMatrix;
-            UVOffset = offset;
+            UVData = uvData;
         }
     }
 }

Data/TextureAtlas.cs

@@ -1,96 +0,0 @@
-using Kav.Data;
-using Microsoft.Xna.Framework;
-using Microsoft.Xna.Framework.Graphics;
-using System.Collections.Generic;
-using System.IO;
-
-namespace Kav
-{
-    public struct TextureAtlasSlice
-    {
-        public int X { get; }
-        public int Y { get; }
-        public int W { get; }
-        public int H { get; }
-
-        public UVData UVData { get; }
-
-        // for use with tiling
-        public Vector2 TiledUVOffset { get; }
-
-        public TextureAtlasSlice(int x, int y, int w, int h, int totalW, int totalH)
-        {
-            X = x;
-            Y = y;
-            W = w;
-            H = h;
-
-            UVData = new UVData(new Vector2(x, y), new Vector2(w, h), new Vector2(totalW, totalH));
-
-            TiledUVOffset = new Vector2(x / (float)totalW, y / (float)totalH);
-        }
-    }
-
-    public class TextureAtlas
-    {
-        public Texture2D Texture { get; }
-        protected List<string> Names { get; } = new List<string>();
-        protected Dictionary<string, TextureAtlasSlice> Slices { get; } = new Dictionary<string, TextureAtlasSlice>();
-
-        public TextureAtlas(GraphicsDevice graphicsDevice, FileInfo atlasMetadataFile)
-        {
-            var atlasData = CrunchAtlasReader.ReadTextureAtlas(atlasMetadataFile);
-
-            var textureData = atlasData.Textures[0];
-
-            using var stream = File.OpenRead(Path.Combine(atlasMetadataFile.DirectoryName, textureData.Name + ".png"));
-            Texture = Texture2D.FromStream(graphicsDevice, stream);
-
-            foreach (var slice in textureData.Images)
-            {
-                Names.Add(slice.N);
-
-                Slices.Add(
-                    slice.N,
-                    new TextureAtlasSlice(
-                        slice.X,
-                        slice.Y,
-                        slice.W,
-                        slice.H,
-                        Texture.Width,
-                        Texture.Height
-                    )
-                );
-            }
-        }
-
-        public TextureAtlasSlice Lookup(string name)
-        {
-            return Slices[name];
-        }
-
-        public string Name(int index)
-        {
-            return Names[index];
-        }
-
-        public int Count()
-        {
-            return Names.Count;
-        }
-    }
-
-    // Assumes all subimages are the same size
-    public class TiledTextureAtlas : TextureAtlas
-    {
-        public int NumRows { get; }
-        public int NumColumns { get; }
-
-        public TiledTextureAtlas(GraphicsDevice graphicsDevice, FileInfo atlasMetadataFile) : base(graphicsDevice, atlasMetadataFile)
-        {
-            var subImageSlice = Slices[Names[0]];
-            NumRows = Texture.Height / subImageSlice.H;
-            NumColumns = Texture.Width / subImageSlice.W;
-        }
-    }
-}

Data/UVData.cs

@@ -1,6 +1,6 @@
 using Microsoft.Xna.Framework;
 
-namespace Kav
+namespace Kav.Data
 {
     public struct UVData
     {
@@ -15,5 +15,10 @@ namespace Kav
             Percentage = subTextureDimensions / atlasDimensions;
             Offset = positionInAtlas / atlasDimensions;
         }
+
+        public Vector4 ToVector4()
+        {
+            return new Vector4(Offset.X, Offset.Y, Percentage.X, Percentage.Y);
+        }
     }
 }

Effects/DeferredPBR_GBufferEffect.cs

@@ -12,17 +12,12 @@ namespace Kav
         EffectParameter normalTextureParam;
         EffectParameter metallicRoughnessTextureParam;
 
+        EffectParameter uvOffsetAndDimensionsParam;
+
         EffectParameter albedoParam;
         EffectParameter metallicParam;
         EffectParameter roughnessParam;
 
-        EffectParameter uvOffsetAndDimensionsParam;
-        EffectParameter isSpriteParam;
-
-        EffectParameter numTextureRowsParam;
-        EffectParameter numTextureColumnsParam;
-
-        EffectParameter vertexShaderIndexParam;
         EffectParameter shaderIndexParam;
 
         Matrix world = Matrix.Identity;
@@ -33,13 +28,7 @@ namespace Kav
         float metallic;
         float roughness;
 
-        Vector2 uvOffset;
-        Vector2 subTextureDimensions;
-
-        bool isSprite = false;
-
-        int numTextureRows = 1;
-        int numTextureColumns = 1;
+        Vector4 uvData;
 
         bool albedoTextureEnabled = false;
         bool metallicRoughnessMapEnabled = false;
@@ -141,54 +130,15 @@ namespace Kav
             }
         }
 
-        public int NumTextureRows
+        public Vector4 UVData
         {
-            get { return numTextureRows; }
+            get { return uvData; }
             set
             {
-                numTextureRows = value;
-                numTextureRowsParam.SetValue(numTextureRows);
+                uvData = value;
+                uvOffsetAndDimensionsParam.SetValue(uvData);
             }
-        }
 
-        public int NumTextureColumns
-        {
-            get { return numTextureColumns; }
-            set
-            {
-                numTextureColumns = value;
-                numTextureColumnsParam.SetValue(numTextureColumns);
-            }
-        }
-
-        public Vector2 UVOffset
-        {
-            get { return uvOffset; }
-            set
-            {
-                uvOffset = value;
-                dirtyFlags |= EffectDirtyFlags.UVOrDimensions;
-            }
-        }
-
-        public Vector2 SubTextureDimensions
-        {
-            get { return subTextureDimensions; }
-            set
-            {
-                subTextureDimensions = value;
-                dirtyFlags |= EffectDirtyFlags.UVOrDimensions;
-            }
-        }
-
-        public bool IsSprite
-        {
-            get { return isSprite; }
-            set
-            {
-                isSprite = value;
-                isSpriteParam.SetValue(isSprite ? 1f : 0f);
-            }
         }
 
         public bool HardwareInstancingEnabled
@@ -248,28 +198,6 @@ namespace Kav
                 dirtyFlags &= ~EffectDirtyFlags.ViewProj;
             }
 
-            if ((dirtyFlags & EffectDirtyFlags.UVOrDimensions) != 0)
-            {
-                uvOffsetAndDimensionsParam.SetValue(new Vector4(
-                    UVOffset.X, UVOffset.Y,
-                    SubTextureDimensions.X, SubTextureDimensions.Y
-                ));
-
-                dirtyFlags &= ~EffectDirtyFlags.UVOrDimensions;
-            }
-
-            if ((dirtyFlags & EffectDirtyFlags.VertexShaderIndex) != 0)
-            {
-                int vertexShaderIndex = 0;
-
-                if (hardwareInstancingEnabled)
-                {
-                    vertexShaderIndex = 1;
-                }
-
-                vertexShaderIndexParam.SetValue(vertexShaderIndex);
-            }
-
             if ((dirtyFlags & EffectDirtyFlags.PixelShaderIndex) != 0)
             {
                 int shaderIndex = 0;
@@ -322,14 +250,9 @@ namespace Kav
             metallicParam = Parameters["MetallicValue"];
             roughnessParam = Parameters["RoughnessValue"];
 
-            numTextureRowsParam = Parameters["NumTextureRows"];
-            numTextureColumnsParam = Parameters["NumTextureColumns"];
-
             uvOffsetAndDimensionsParam = Parameters["UVOffsetAndDimensions"];
-            isSpriteParam = Parameters["IsSprite"];
 
             shaderIndexParam = Parameters["PixelShaderIndex"];
-            vertexShaderIndexParam = Parameters["VertexShaderIndex"];
         }
     }
 }

Effects/DeferredPBR_PointLightEffect.cs

@@ -77,7 +77,7 @@ namespace Kav
         public DeferredPBR_PointLightEffect(DeferredPBR_PointLightEffect cloneSource) : base(cloneSource)
         {
             CacheEffectParameters();
-
+            
             GPosition = cloneSource.GPosition;
             GAlbedo = cloneSource.GAlbedo;
             GNormal = cloneSource.GNormal;

Effects/DiffuseLitSpriteEffect.cs

@@ -33,8 +33,7 @@ namespace Kav
         Matrix view = Matrix.Identity;
         Matrix projection = Matrix.Identity;
 
-        Vector2 uvOffset;
-        Vector2 subTextureDimensions;
+        Vector4 uvData;
 
         EffectDirtyFlags dirtyFlags = EffectDirtyFlags.All;
 
@@ -115,23 +114,13 @@ namespace Kav
             }
         }
 
-        public Vector2 UVOffset
+        public Vector4 UVData
         {
-            get { return uvOffset; }
+            get { return uvData; }
             set
             {
-                uvOffset = value;
-                dirtyFlags |= EffectDirtyFlags.UVOrDimensions;
-            }
-        }
-
-        public Vector2 SubTextureDimensions
-        {
-            get { return subTextureDimensions; }
-            set
-            {
-                subTextureDimensions = value;
-                dirtyFlags |= EffectDirtyFlags.UVOrDimensions;
+                uvData = value;
+                dirtyFlags |= EffectDirtyFlags.UVData;
             }
         }
 
@@ -168,14 +157,11 @@ namespace Kav
                 dirtyFlags &= ~EffectDirtyFlags.WorldViewProj;
             }
 
-            if ((dirtyFlags & EffectDirtyFlags.UVOrDimensions) != 0)
+            if ((dirtyFlags & EffectDirtyFlags.UVData) != 0)
             {
-                uvOffsetAndDimensionsParam.SetValue(new Vector4(
-                    UVOffset.X, UVOffset.Y,
-                    SubTextureDimensions.X, SubTextureDimensions.Y
-                ));
+                uvOffsetAndDimensionsParam.SetValue(uvData);
 
-                dirtyFlags &= ~EffectDirtyFlags.UVOrDimensions;
+                dirtyFlags &= ~EffectDirtyFlags.UVData;
             }
 
             if ((dirtyFlags & EffectDirtyFlags.PixelShaderIndex) != 0)

Effects/EffectHelpers.cs

@@ -11,7 +11,7 @@ namespace Kav
         VertexShaderIndex = 8,
         PixelShaderIndex = 16,
         ViewProj = 32,
-        UVOrDimensions = 64,
+        UVData = 64,
         All = -1
     }
 }

Effects/HLSL/DeferredPBR_GBufferEffect.fx

@@ -4,32 +4,31 @@ DECLARE_TEXTURE(AlbedoTexture, 0);
 DECLARE_TEXTURE(NormalTexture, 1);
 DECLARE_TEXTURE(MetallicRoughnessTexture, 2);
 
+float3 AlbedoValue;
+float MetallicValue;
+float RoughnessValue;
+
 float4 UVOffsetAndDimensions;
-float IsSprite;
 
-BEGIN_CONSTANTS
-
-    float3 AlbedoValue                         _ps(c0)    _cb(c0);
-    float MetallicValue                        _ps(c1)    _cb(c1);
-    float RoughnessValue                       _ps(c2)    _cb(c2);
-
-    int NumTextureRows              _vs(c9)               _cb(c3);
-    int NumTextureColumns           _vs(c10)              _cb(c4);
-
-MATRIX_CONSTANTS
-
-    float4x4 World                  _vs(c0)               _cb(c7);
-    float4x4 ViewProjection         _vs(c4)               _cb(c11);
-
-END_CONSTANTS
+float4x4 World;
+float4x4 ViewProjection;
 
 struct VertexInput
 {
-    float4 Position : POSITION;
+    float3 Position : POSITION;
     float3 Normal   : NORMAL;
     float2 TexCoord : TEXCOORD;
 };
 
+struct VertexInstancedInput
+{
+    float3 Position : POSITION;
+    float3 Normal   : NORMAL;
+    float2 TexCoord : TEXCOORD0;
+    float3 Translation : TEXCOORD2;
+    float2 UVData : TANGENT;
+};
+
 struct PixelInput
 {
     float4 Position      : SV_POSITION;
@@ -56,8 +55,8 @@ PixelInput main_vs(VertexInput input)
     output.NormalWorld = normalize(mul(input.Normal, World));
 
     float2 texCoord;
-    texCoord.x = (input.TexCoord.x * UVOffsetAndDimensions.z) + UVOffsetAndDimensions.x;
-    texCoord.y = (input.TexCoord.y * UVOffsetAndDimensions.w) + UVOffsetAndDimensions.y;
+    texCoord.x = (input.TexCoord.x / UVOffsetAndDimensions.z) + UVOffsetAndDimensions.x;
+    texCoord.y = (input.TexCoord.y / UVOffsetAndDimensions.w) + UVOffsetAndDimensions.y;
     output.TexCoord = texCoord;
 
     float4x4 worldViewProjection = mul(World, ViewProjection);
@@ -67,9 +66,7 @@ PixelInput main_vs(VertexInput input)
 }
 
 PixelInput instanced_vs(
-    VertexInput input,
-    float3 Translation : TEXCOORD2,
-    float2 UVOffset    : TEXCOORD5
+    VertexInstancedInput input
 ) {
     PixelInput output;
 
@@ -77,7 +74,7 @@ PixelInput instanced_vs(
         float4(1, 0, 0, 0),
         float4(0, 1, 0, 0),
         float4(0, 0, 1, 0),
-        float4(Translation.x, Translation.y, Translation.z, 1)
+        float4(input.Translation.x, input.Translation.y, input.Translation.z, 1)
     );
 
     float4x4 worldViewProjection = mul(world, ViewProjection);
@@ -86,9 +83,9 @@ PixelInput instanced_vs(
     output.NormalWorld = mul(input.Normal, world);
 
     float2 texCoord;
-    texCoord.x = (input.TexCoord.x / NumTextureColumns + UVOffset.x);
-    texCoord.y = (input.TexCoord.y / NumTextureRows + UVOffset.y);
-    output.TexCoord = texCoord;
+    texCoord.x = (input.TexCoord.x / 8) + input.UVData.x;
+    texCoord.y = (input.TexCoord.y / 1) + input.UVData.y;
+    output.TexCoord = input.TexCoord;
 
     output.Position = mul(input.Position, worldViewProjection);
 
@@ -120,7 +117,7 @@ PixelOutput NonePS(PixelInput input)
     PixelOutput output;
 
     output.gPosition = float4(input.PositionWorld, 1.0);
-    output.gNormal = float4(normalize(input.NormalWorld), IsSprite);
+    output.gNormal = float4(normalize(input.NormalWorld), 1.0);
     output.gAlbedo = float4(AlbedoValue, 1.0);
     output.gMetallicRoughness = float4(MetallicValue, RoughnessValue, 0.0, 1.0);
 
@@ -132,12 +129,10 @@ PixelOutput AlbedoPS(PixelInput input)
     PixelOutput output;
 
     output.gPosition = float4(input.PositionWorld, 1.0);
-    output.gNormal = float4(normalize(input.NormalWorld), IsSprite);
+    output.gNormal = float4(normalize(input.NormalWorld), 1.0);
     output.gAlbedo = SAMPLE_TEXTURE(AlbedoTexture, input.TexCoord);
     output.gMetallicRoughness = float4(MetallicValue, RoughnessValue, 0.0, 1.0);
 
-    if (output.gAlbedo.a == 0.0) { discard; }
-
     return output;
 }
 
@@ -146,7 +141,7 @@ PixelOutput MetallicRoughnessPS(PixelInput input)
     PixelOutput output;
 
     output.gPosition = float4(input.PositionWorld, 1.0);
-    output.gNormal = float4(normalize(input.NormalWorld), IsSprite);
+    output.gNormal = float4(normalize(input.NormalWorld), 1.0);
     output.gAlbedo = float4(AlbedoValue, 1.0);
     output.gMetallicRoughness = SAMPLE_TEXTURE(MetallicRoughnessTexture, input.TexCoord);
 
@@ -158,7 +153,7 @@ PixelOutput NormalPS(PixelInput input)
     PixelOutput output;
 
     output.gPosition = float4(input.PositionWorld, 1.0);
-    output.gNormal = float4(GetNormalFromMap(input.PositionWorld, input.TexCoord, input.NormalWorld), IsSprite);
+    output.gNormal = float4(GetNormalFromMap(input.PositionWorld, input.TexCoord, input.NormalWorld), 1.0);
     output.gAlbedo = float4(AlbedoValue, 1.0);
     output.gMetallicRoughness = float4(MetallicValue, RoughnessValue, 0.0, 1.0);
 
@@ -170,12 +165,10 @@ PixelOutput AlbedoMetallicRoughnessPS(PixelInput input)
     PixelOutput output;
 
     output.gPosition = float4(input.PositionWorld, 1.0);
-    output.gNormal = float4(normalize(input.NormalWorld), IsSprite);
+    output.gNormal = float4(normalize(input.NormalWorld), 1.0);
     output.gAlbedo = SAMPLE_TEXTURE(AlbedoTexture, input.TexCoord);
     output.gMetallicRoughness = SAMPLE_TEXTURE(MetallicRoughnessTexture, input.TexCoord);
 
-    if (output.gAlbedo.a == 0.0) { discard; }
-
     return output;
 }
 
@@ -184,12 +177,10 @@ PixelOutput AlbedoNormalPS(PixelInput input)
     PixelOutput output;
 
     output.gPosition = float4(input.PositionWorld, 1.0);
-    output.gNormal = float4(GetNormalFromMap(input.PositionWorld, input.TexCoord, input.NormalWorld), IsSprite);
+    output.gNormal = float4(GetNormalFromMap(input.PositionWorld, input.TexCoord, input.NormalWorld), 1.0);
     output.gAlbedo = SAMPLE_TEXTURE(AlbedoTexture, input.TexCoord);
     output.gMetallicRoughness = float4(MetallicValue, RoughnessValue, 0.0, 1.0);
 
-    if (output.gAlbedo.a == 0.0) { discard; }
-
     return output;
 }
 
@@ -198,7 +189,7 @@ PixelOutput MetallicRoughnessNormalPS(PixelInput input)
     PixelOutput output;
 
     output.gPosition = float4(input.PositionWorld, 1.0);
-    output.gNormal = float4(GetNormalFromMap(input.PositionWorld, input.TexCoord, input.NormalWorld), IsSprite);
+    output.gNormal = float4(GetNormalFromMap(input.PositionWorld, input.TexCoord, input.NormalWorld), 1.0);
     output.gAlbedo = float4(AlbedoValue, 1.0);
     output.gMetallicRoughness = SAMPLE_TEXTURE(MetallicRoughnessTexture, input.TexCoord);
 
@@ -210,28 +201,13 @@ PixelOutput AlbedoMetallicRoughnessNormalMapPS(PixelInput input)
     PixelOutput output;
 
     output.gPosition = float4(input.PositionWorld, 1.0);
-    output.gNormal = float4(GetNormalFromMap(input.PositionWorld, input.TexCoord, input.NormalWorld), IsSprite);
+    output.gNormal = float4(GetNormalFromMap(input.PositionWorld, input.TexCoord, input.NormalWorld), 1.0);
     output.gAlbedo = SAMPLE_TEXTURE(AlbedoTexture, input.TexCoord);
     output.gMetallicRoughness = SAMPLE_TEXTURE(MetallicRoughnessTexture, input.TexCoord);
 
-    if (output.gAlbedo.a == 0.0) { discard; }
-
     return output;
 }
 
-VertexShader VSArray[2] =
-{
-    compile vs_3_0 main_vs(),
-    compile vs_3_0 instanced_vs()
-};
-
-int VSIndices[2] =
-{
-    0, 1
-};
-
-int VertexShaderIndex = 0;
-
 PixelShader PSArray[8] =
 {
     compile ps_3_0 NonePS(),
@@ -258,7 +234,7 @@ Technique GBuffer
 {
     Pass
     {
-        VertexShader = (VSArray[VSIndices[VertexShaderIndex]]);
+        VertexShader = compile vs_3_0 instanced_vs();
         PixelShader  = (PSArray[PSIndices[PixelShaderIndex]]);
     }
 }

Effects/HLSL/DeferredPBR_PointLightEffect.fx

@@ -1,7 +1,7 @@
 // Assumes you are drawing a sphere!!
 
 #include "Macros.fxh" //from FNA
-#include "Lighting.fxh"
+#include "Lighting.fxh" 
 #include "Shadow.fxh"
 
 DECLARE_TEXTURE(gPosition, 0);
@@ -13,7 +13,7 @@ DECLARE_CUBEMAP(shadowMap, 4);
 BEGIN_CONSTANTS
 
     float3 EyePosition                      _ps(c0)     _cb(c0);
-
+    
     float3 PointLightPosition               _ps(c1)     _cb(c1);
     float3 PointLightColor                  _ps(c2)     _cb(c2);
 
@@ -42,7 +42,7 @@ PixelInput main_vs(VertexInput input)
 
     output.Position = mul(input.Position, WorldViewProjection);
     output.ScreenPosition = output.Position;
-
+    
     return output;
 }
 
@@ -78,34 +78,19 @@ float4 main_ps(PixelInput input) : SV_TARGET0
 {
     input.ScreenPosition.xy /= input.ScreenPosition.w;
     float2 texCoord = 0.5f * float2(input.ScreenPosition.x,-input.ScreenPosition.y) + 0.5f;
-
+    
     float3 worldPosition = SAMPLE_TEXTURE(gPosition, texCoord).rgb;
-    float4 normalSample = SAMPLE_TEXTURE(gNormal, texCoord);
-    float3 normal = normalSample.xyz;
-    float isSprite = normalSample.a;
+    float3 normal = SAMPLE_TEXTURE(gNormal, texCoord).xyz;
     float3 albedo = SAMPLE_TEXTURE(gAlbedo, texCoord).rgb;
     float2 metallicRoughness = SAMPLE_TEXTURE(gMetallicRoughness, texCoord).rg;
 
-    if (isSprite == 1.0)
-    {
-        float3 lightDir = PointLightPosition - worldPosition;
-        float3 L = normalize(lightDir);
-        float distance = length(lightDir);
-        float attenuation = 1.0 / (distance * distance);
-        float3 radiance = PointLightColor * attenuation;
-
-        return float4(albedo * radiance * 0.1, 1.0);
-    }
-    else
-    {
-        return ComputeColor(
-            worldPosition,
-            normal,
-            albedo,
-            metallicRoughness.r,
-            metallicRoughness.g
-        );
-    }
+    return ComputeColor(
+        worldPosition,
+        normal,
+        albedo,
+        metallicRoughness.r,
+        metallicRoughness.g
+    );
 }
 
 Technique DeferredPBR_Point

Effects/HLSL/DiffuseLitSpriteEffect.fx

@@ -43,8 +43,8 @@ PixelShaderInput main_vs(VertexShaderInput input)
     output.PositionWS = mul(input.Position, World).xyz;
 
     float2 texCoord;
-    texCoord.x = (input.TexCoord.x * UVOffsetAndDimensions.z) + UVOffsetAndDimensions.x;
-    texCoord.y = (input.TexCoord.y * UVOffsetAndDimensions.w) + UVOffsetAndDimensions.y;
+    texCoord.x = (input.TexCoord.x / UVOffsetAndDimensions.z) + UVOffsetAndDimensions.x;
+    texCoord.y = (input.TexCoord.y / UVOffsetAndDimensions.w) + UVOffsetAndDimensions.y;
     output.TexCoord = texCoord;
 
     return output;
@@ -98,9 +98,6 @@ float4 LightColor(float3 worldPosition, float3 worldNormal)
 float4 WithoutNormalMap(PixelShaderInput input) : COLOR0
 {
     float4 tex = SAMPLE_TEXTURE(Texture, input.TexCoord);
-
-    if (tex.a == 0.0) { discard; }
-
     float3 normalWS = normalize(input.NormalWS);
 
     return tex * LightColor(input.PositionWS, normalWS);
@@ -109,9 +106,6 @@ float4 WithoutNormalMap(PixelShaderInput input) : COLOR0
 float4 WithNormalMap(PixelShaderInput input) : COLOR0
 {
     float4 tex = SAMPLE_TEXTURE(Texture, input.TexCoord);
-
-    if (tex.a == 0.0) { discard; }
-
     float3 normalWS = GetNormalFromMap(input.PositionWS, input.TexCoord, input.NormalWS);
 
     return tex * LightColor(input.PositionWS, normalWS);

Effects/HLSL/PaletteCrushEffect.fx

@@ -1,5 +1,7 @@
 #include "Macros.fxh"
 
+#define FLT_MAX 3.402823466e+38
+
 DECLARE_TEXTURE(Texture, 0);
 DECLARE_TEXTURE(Palette, 1);
 
@@ -38,12 +40,11 @@ float4 main_ps(PixelInput input) : SV_TARGET0
 	float3 sampled_color = sampled.rgb;
 	
 	float3 closest_color = float3(0, 0, 0);
-	float closest_dist = 100000;
+	float closest_dist = FLT_MAX;
 
 	for (int i = 0; i < PaletteWidth; i++)
 	{
-		float texX = (i / (float)PaletteWidth);
-		float3 palette_color = SAMPLE_TEXTURE(Palette, float2(texX, 0));
+		float3 palette_color = SAMPLE_TEXTURE(Palette, float2(i / (float)PaletteWidth, 0));
 		float dist = distance(palette_color, sampled_color);
 		if (dist < closest_dist)
 		{

Geometry/Interfaces/ICullable.cs

@@ -5,5 +5,6 @@ namespace Kav
     public interface ICullable
     {
         BoundingBox BoundingBox { get; }
+        Matrix TransformMatrix { get; }
     }
 }

Geometry/Interfaces/IGBufferDrawable.cs

@@ -1,3 +1,4 @@
+using Kav.Data;
 using Microsoft.Xna.Framework;
 using Microsoft.Xna.Framework.Graphics;
 
@@ -12,8 +13,5 @@ namespace Kav
         Texture2D AlbedoTexture { get; }
         Texture2D NormalTexture { get; }
         Texture2D MetallicRoughnessTexture { get; }
-
-        int NumTextureRows { get; }
-        int NumTextureColumns { get; }
     }
 }

Geometry/Interfaces/ITransformable.cs

@@ -1,9 +0,0 @@
-using Microsoft.Xna.Framework;
-
-namespace Kav
-{
-    public interface ITransformable
-    {
-        Matrix TransformMatrix { get; }
-    }
-}

Geometry/Interfaces/IUVDrawable.cs

@@ -0,0 +1,9 @@
+using Kav.Data;
+
+namespace Kav
+{
+    public interface IUVDrawable
+    {
+        UVData UVData { get; }
+    }
+}

Geometry/MeshPart.cs

@@ -3,7 +3,7 @@ using Microsoft.Xna.Framework.Graphics;
 
 namespace Kav
 {
-    public class MeshPart : IIndexDrawable, IGBufferDrawable, ICullable, IHasVertexPositions
+    public class MeshPart : IIndexDrawable, IGBufferDrawable, IHasVertexPositions
     {
         public IndexBuffer IndexBuffer { get; }
         public VertexBuffer VertexBuffer { get; }
@@ -38,9 +38,6 @@ namespace Kav
         public float Metallic { get; set; } = 0.5f;
         public float Roughness { get; set; } = 0.5f;
 
-        public int NumTextureRows { get; set; } = 1;
-        public int NumTextureColumns { get; set; } = 1;
-
         public bool DisableAlbedoMap { get; set; } = false;
         public bool DisableNormalMap { get; set; } = false;
         public bool DisableMetallicRoughnessMap { get; set; } = false;

Geometry/MeshSprite.cs

@@ -4,7 +4,7 @@ using Microsoft.Xna.Framework.Graphics;
 
 namespace Kav
 {
-    public class SpriteMesh : ICullable, IIndexDrawable
+    public class MeshSprite : IIndexDrawable
     {
         public enum FlipOptions
         {
@@ -14,6 +14,7 @@ namespace Kav
             Both
         }
 
+        private static readonly int PixelScale = 40;
         private static readonly short[] Indices = new short[]
         {
             0,
@@ -24,16 +25,21 @@ namespace Kav
             2
         };
 
+        public Texture2D Texture { get; }
+        public Texture2D Normal { get; }
+
         public IndexBuffer IndexBuffer { get; }
         public VertexBuffer VertexBuffer { get; }
         public BoundingBox BoundingBox { get; }
 
-        public SpriteMesh(
+        public MeshSprite(
             GraphicsDevice graphicsDevice,
-            int width,
-            int height,
+            Texture2D texture,
             FlipOptions flipOptions
         ) {
+            Texture = texture;
+            Normal = null;
+
 			IndexBuffer = new IndexBuffer(
 				graphicsDevice,
 				IndexElementSize.SixteenBits,
@@ -42,7 +48,7 @@ namespace Kav
 			);
             IndexBuffer.SetData(Indices);
 
-            var vertexArray = GenerateVertexArray(width, height, flipOptions);
+            var vertexArray = GenerateVertexArray(Texture, flipOptions);
 
             VertexBuffer = new VertexBuffer(
                 graphicsDevice,
@@ -55,11 +61,38 @@ namespace Kav
             BoundingBox = BoundingBox.CreateFromPoints(Positions(vertexArray));
         }
 
-        private static VertexPositionNormalTexture[] GenerateVertexArray(int pixelWidth, int pixelHeight, FlipOptions flipOptions)
-        {
-            var width = pixelWidth / (float)40;
-            var height = pixelHeight / (float)40;
+        public MeshSprite(
+            GraphicsDevice graphicsDevice,
+            Texture2D texture,
+            Texture2D normal,
+            FlipOptions flipOptions
+        ) {
+            Texture = texture;
+            Normal = normal;
 
+			IndexBuffer = new IndexBuffer(
+				graphicsDevice,
+				IndexElementSize.SixteenBits,
+				6,
+				BufferUsage.WriteOnly
+			);
+            IndexBuffer.SetData(Indices);
+
+            var vertexArray = GenerateVertexArray(Texture, flipOptions);
+
+            VertexBuffer = new VertexBuffer(
+                graphicsDevice,
+                typeof(VertexPositionNormalTexture),
+                4,
+                BufferUsage.WriteOnly
+            );
+            VertexBuffer.SetData(vertexArray);
+
+            BoundingBox = BoundingBox.CreateFromPoints(Positions(vertexArray));
+        }
+
+        private static VertexPositionNormalTexture[] GenerateVertexArray(Texture2D texture, FlipOptions flipOptions)
+        {
             VertexPositionNormalTexture[] result = new VertexPositionNormalTexture[4];
 
             var xLeft = 0;
@@ -79,20 +112,20 @@ namespace Kav
                 yBottom = 0;
             }
 
-            result[0].Position = new Vector3(-width / 2, height / 2, 0);
-            result[0].Normal = new Vector3(0, 0, -1);
+            result[0].Position = new Vector3(-texture.Width / 2, texture.Height / 2, 0) / PixelScale;
+            result[0].Normal = new Vector3(0, 0, 1);
             result[0].TextureCoordinate = new Vector2(xLeft, yTop);
 
-            result[1].Position = new Vector3(width / 2, height / 2, 0);
-            result[1].Normal = new Vector3(0, 0, -1);
+            result[1].Position = new Vector3(texture.Width / 2, texture.Height / 2, 0) / PixelScale;
+            result[1].Normal = new Vector3(0, 0, 1);
             result[1].TextureCoordinate = new Vector2(xRight, yTop);
 
-            result[2].Position = new Vector3(-width / 2, -height / 2, 0);
-            result[2].Normal = new Vector3(0, 0, -1);
+            result[2].Position = new Vector3(-texture.Width / 2, -texture.Height / 2, 0) / PixelScale;
+            result[2].Normal = new Vector3(0, 0, 1);
             result[2].TextureCoordinate = new Vector2(xLeft, yBottom);
 
-            result[3].Position = new Vector3(width / 2, -height / 2, 0);
-            result[3].Normal = new Vector3(0, 0, -1);
+            result[3].Position = new Vector3(texture.Width / 2, -texture.Height / 2, 0) / PixelScale;
+            result[3].Normal = new Vector3(0, 0, 1);
             result[3].TextureCoordinate = new Vector2(xRight, yBottom);
 
             return result;

Geometry/Model.cs

@@ -2,7 +2,7 @@ using Microsoft.Xna.Framework;
 
 namespace Kav
 {
-    public class Model : ICullable
+    public class Model
     {
         public Mesh[] Meshes { get; }
         public BoundingBox BoundingBox { get; }

Kav.Core.csproj

@@ -2,7 +2,6 @@
 
   <PropertyGroup>
     <TargetFramework>netstandard2.0</TargetFramework>
-    <LangVersion>8.0</LangVersion>
     <RootNamespace>Kav</RootNamespace>
     <Authors>Evan Hemsley</Authors>
     <Copyright>Evan Hemsley 2020</Copyright>

Kav.Framework.csproj

@@ -2,7 +2,6 @@
 
   <PropertyGroup>
     <TargetFramework>netstandard2.0</TargetFramework>
-    <LangVersion>8.0</LangVersion>
     <RootNamespace>Kav</RootNamespace>
     <Authors>Evan Hemsley</Authors>
     <Copyright>Evan Hemsley 2020</Copyright>

Loaders/CrunchAtlasReader.cs

@@ -1,18 +0,0 @@
-using System.IO;
-using System.Text.Json;
-
-namespace Kav
-{
-    public static class CrunchAtlasReader
-    {
-        static JsonSerializerOptions options = new JsonSerializerOptions
-        {
-            PropertyNameCaseInsensitive = true
-        };
-
-        public static CrunchTextureAtlasData ReadTextureAtlas(FileInfo file)
-        {
-            return JsonSerializer.Deserialize<CrunchTextureAtlasData>(File.ReadAllText(file.FullName), options);
-        }
-    }
-}

Loaders/CrunchTextureAtlasData.cs

@@ -1,22 +0,0 @@
-namespace Kav
-{
-    public struct CrunchTextureAtlasData
-    {
-        public CrunchTextureAtlasTextureData[] Textures { get; set; }
-    }
-
-    public struct CrunchTextureAtlasTextureData
-    {
-        public string Name { get; set; }
-        public CrunchTextureAtlasImageData[] Images { get; set; }
-    }
-
-    public struct CrunchTextureAtlasImageData
-    {
-        public string N { get; set; }
-        public int X { get; set; }
-        public int Y { get; set; }
-        public int W { get; set; }
-        public int H { get; set; }
-    }
-}

Renderer.cs

@@ -125,7 +125,7 @@ namespace Kav
         ) {
             GraphicsDevice.SetRenderTarget(renderTarget);
 
-            GraphicsDevice.DepthStencilState = DepthStencilState.Default;
+            GraphicsDevice.DepthStencilState = DepthStencilState.DepthRead;
             GraphicsDevice.RasterizerState = RasterizerState.CullNone;
             GraphicsDevice.SamplerStates[0] = SamplerState.PointClamp;
             GraphicsDevice.SamplerStates[1] = SamplerState.PointClamp;
@@ -159,23 +159,17 @@ namespace Kav
 
             var boundingFrustum = new BoundingFrustum(camera.View * camera.Projection);
 
-            foreach (var data in meshSpriteDrawDatas)
+            foreach (var data in FrustumCull(boundingFrustum, meshSpriteDrawDatas))
             {
                 var matrix = BillboardTransforms(camera, data.TransformMatrix, data.BillboardConstraint);
 
-                if (FrustumCull(boundingFrustum, data.MeshSprite, matrix))
-                {
-                    continue;
-                }
-
-                DiffuseLitSpriteEffect.NormalMapEnabled = data.Normal != null;
+                DiffuseLitSpriteEffect.NormalMapEnabled = data.MeshSprite.Normal != null;
 
                 DiffuseLitSpriteEffect.World = matrix;
-                DiffuseLitSpriteEffect.UVOffset = data.UVOffset.Offset;
-                DiffuseLitSpriteEffect.SubTextureDimensions = data.UVOffset.Percentage;
+                DiffuseLitSpriteEffect.UVData = data.UVData.ToVector4();
 
-                GraphicsDevice.Textures[0] = data.Texture;
-                GraphicsDevice.Textures[1] = data.Normal;
+                GraphicsDevice.Textures[0] = data.MeshSprite.Texture;
+                GraphicsDevice.Textures[1] = data.MeshSprite.Normal;
 
                 GraphicsDevice.SetVertexBuffer(data.MeshSprite.VertexBuffer);
                 GraphicsDevice.Indices = data.MeshSprite.IndexBuffer;
@@ -196,51 +190,6 @@ namespace Kav
             }
         }
 
-        public void RenderMeshSpriteGBuffer(
-            RenderTargetBinding[] gBuffer,
-            PerspectiveCamera camera,
-            IEnumerable<MeshSpriteDrawData> meshSpriteDrawDatas,
-            DepthStencilState depthStencilState
-        ) {
-            GraphicsDevice.SetRenderTargets(gBuffer);
-            GraphicsDevice.RasterizerState = RasterizerState.CullNone;
-            GraphicsDevice.DepthStencilState = depthStencilState;
-            GraphicsDevice.BlendState = BlendState.AlphaBlend;
-
-            Deferred_GBufferEffect.HardwareInstancingEnabled = false;
-            Deferred_GBufferEffect.IsSprite = true;
-
-            Deferred_GBufferEffect.View = camera.View;
-            Deferred_GBufferEffect.Projection = camera.Projection;
-
-            var boundingFrustum = new BoundingFrustum(camera.View * camera.Projection);
-
-            foreach (var data in meshSpriteDrawDatas)
-            {
-                var matrix = BillboardTransforms(camera, data.TransformMatrix, data.BillboardConstraint);
-
-                if (FrustumCull(boundingFrustum, data.MeshSprite, matrix))
-                {
-                    continue;
-                }
-
-                Deferred_GBufferEffect.World = matrix;
-
-                Deferred_GBufferEffect.UVOffset = data.UVOffset.Offset;
-                Deferred_GBufferEffect.SubTextureDimensions = data.UVOffset.Percentage;
-
-                Deferred_GBufferEffect.Albedo = Color.White.ToVector3();
-                Deferred_GBufferEffect.Metallic = 0f;
-                Deferred_GBufferEffect.Roughness = 1f;
-
-                Deferred_GBufferEffect.AlbedoTexture = data.Texture;
-                Deferred_GBufferEffect.NormalTexture = data.Normal;
-                Deferred_GBufferEffect.MetallicRoughnessTexture = null;
-
-                RenderIndexed(GraphicsDevice, data, Deferred_GBufferEffect);
-            }
-        }
-
         private static Matrix BillboardTransforms(
             PerspectiveCamera camera,
             Matrix transform,
@@ -277,13 +226,13 @@ namespace Kav
         public static void CullAndRenderIndexed<T, U>(
             GraphicsDevice graphicsDevice,
             BoundingFrustum boundingFrustum,
-            IEnumerable<(T, Matrix)> drawableTransformPairs,
+            IEnumerable<T> drawables,
             U effect
         ) where T : IIndexDrawable, ICullable where U : Effect, IHasWorldMatrix
         {
-            foreach (var (drawable, transform) in FrustumCull(boundingFrustum, drawableTransformPairs))
+            foreach (var drawable in FrustumCull(boundingFrustum, drawables))
             {
-                effect.World = transform;
+                effect.World = drawable.TransformMatrix;
 
                 RenderIndexed(
                     graphicsDevice,
@@ -361,7 +310,7 @@ namespace Kav
         public void RenderDepthIndexed<T>(
             RenderTarget2D renderTarget,
             PerspectiveCamera camera,
-            IEnumerable<(T, Matrix)> drawableTransforms
+            IEnumerable<T> drawables
         ) where T : ICullable, IIndexDrawable
         {
             GraphicsDevice.SetRenderTarget(renderTarget);
@@ -373,26 +322,11 @@ namespace Kav
             CullAndRenderIndexed(
                 GraphicsDevice,
                 new BoundingFrustum(camera.View * camera.Projection),
-                drawableTransforms,
+                drawables,
                 SimpleDepthEffect
             );
         }
 
-        public void RenderDepthIndexed<T>(
-            RenderTarget2D renderTarget,
-            PerspectiveCamera camera,
-            T drawable,
-            DepthStencilState depthStencilState
-        ) where T : IIndexDrawable {
-            GraphicsDevice.SetRenderTarget(renderTarget);
-            GraphicsDevice.DepthStencilState = depthStencilState;
-
-            SimpleDepthEffect.View = camera.View;
-            SimpleDepthEffect.Projection = camera.Projection;
-
-            RenderIndexed(GraphicsDevice, drawable, SimpleDepthEffect);
-        }
-
         public void RenderSkybox(
             RenderTarget2D renderTarget,
             PerspectiveCamera camera,
@@ -436,15 +370,11 @@ namespace Kav
             GraphicsDevice.BlendState = BlendState.Opaque;
 
             Deferred_GBufferEffect.HardwareInstancingEnabled = true;
-            Deferred_GBufferEffect.IsSprite = false;
 
             Deferred_GBufferEffect.Albedo = drawable.Albedo;
             Deferred_GBufferEffect.Metallic = drawable.Metallic;
             Deferred_GBufferEffect.Roughness = drawable.Roughness;
 
-            Deferred_GBufferEffect.NumTextureRows = drawable.NumTextureRows;
-            Deferred_GBufferEffect.NumTextureColumns = drawable.NumTextureColumns;
-
             Deferred_GBufferEffect.AlbedoTexture = drawable.AlbedoTexture;
             Deferred_GBufferEffect.NormalTexture = drawable.NormalTexture;
             Deferred_GBufferEffect.MetallicRoughnessTexture = drawable.MetallicRoughnessTexture;
@@ -478,22 +408,21 @@ namespace Kav
         public void RenderGBufferIndexed<T>(
             RenderTargetBinding[] gBuffer,
             PerspectiveCamera camera,
-            IEnumerable<(T, Matrix)> drawableTransforms
-        ) where T : ICullable, IIndexDrawable, IGBufferDrawable {
+            IEnumerable<T> drawables
+        ) where T : ICullable, IIndexDrawable, IUVDrawable, IGBufferDrawable {
             GraphicsDevice.SetRenderTargets(gBuffer);
             GraphicsDevice.DepthStencilState = DepthStencilState.Default;
             GraphicsDevice.BlendState = BlendState.Opaque;
 
-            Deferred_GBufferEffect.IsSprite = false;
             Deferred_GBufferEffect.HardwareInstancingEnabled = false;
             Deferred_GBufferEffect.View = camera.View;
             Deferred_GBufferEffect.Projection = camera.Projection;
 
             var boundingFrustum = new BoundingFrustum(camera.View * camera.Projection);
 
-            foreach (var (drawable, transform) in FrustumCull(boundingFrustum, drawableTransforms))
+            foreach (var drawable in FrustumCull(boundingFrustum, drawables))
             {
-                Deferred_GBufferEffect.World = transform;
+                Deferred_GBufferEffect.World = drawable.TransformMatrix;
 
                 Deferred_GBufferEffect.HardwareInstancingEnabled = false;
 
@@ -501,6 +430,8 @@ namespace Kav
                 Deferred_GBufferEffect.Metallic = drawable.Metallic;
                 Deferred_GBufferEffect.Roughness = drawable.Roughness;
 
+                Deferred_GBufferEffect.UVData = drawable.UVData.ToVector4();
+
                 Deferred_GBufferEffect.AlbedoTexture = drawable.AlbedoTexture;
                 Deferred_GBufferEffect.NormalTexture = drawable.NormalTexture;
                 Deferred_GBufferEffect.MetallicRoughnessTexture = drawable.MetallicRoughnessTexture;
@@ -746,7 +677,7 @@ namespace Kav
 
         public void RenderDirectionalShadowsIndexed<T>(
             DirectionalShadowMapData shadowMapData,
-            IEnumerable<(T, Matrix)> drawableTransforms
+            IEnumerable<T> drawableTransforms
         ) where T : ICullable, IIndexDrawable {
             // render the individual shadow cascades
             for (var i = 0; i < shadowMapData.NumShadowCascades; i++)
@@ -762,7 +693,7 @@ namespace Kav
         private void RenderDirectionalShadowMapIndexed<T>(
             DirectionalShadowMapData shadowMapData,
             int shadowCascadeIndex,
-            IEnumerable<(T, Matrix)> drawableTransforms
+            IEnumerable<T> drawables
         ) where T : ICullable, IIndexDrawable {
             GraphicsDevice.SetRenderTarget(shadowMapData.ShadowMaps[shadowCascadeIndex]);
             GraphicsDevice.DepthStencilState = DepthStencilState.Default;
@@ -774,7 +705,7 @@ namespace Kav
             CullAndRenderIndexed(
                 GraphicsDevice,
                 new BoundingFrustum(SimpleDepthEffect.View * SimpleDepthEffect.Projection),
-                drawableTransforms,
+                drawables,
                 SimpleDepthEffect
             );
         }
@@ -825,7 +756,7 @@ namespace Kav
 
         public void RenderPointShadowMapIndexed<T>(
             RenderTargetCube pointShadowCubeMap,
-            IEnumerable<(T, Matrix)> modelTransforms,
+            IEnumerable<T> drawables,
             PointLight pointLight
         ) where T : ICullable, IIndexDrawable {
             GraphicsDevice.DepthStencilState = DepthStencilState.Default;
@@ -893,7 +824,7 @@ namespace Kav
                 CullAndRenderIndexed(
                     GraphicsDevice,
                     new BoundingFrustum(LinearDepthEffect.View * LinearDepthEffect.Projection),
-                    modelTransforms,
+                    drawables,
                     LinearDepthEffect
                 );
             }
@@ -905,7 +836,7 @@ namespace Kav
             VertexBuffer instanceVertexBuffer,
             int numInstances,
             PointLight pointLight
-        ) where T : ICullable, IIndexDrawable
+        ) where T : IIndexDrawable
         {
             GraphicsDevice.DepthStencilState = DepthStencilState.Default;
             GraphicsDevice.BlendState = BlendState.Opaque;
@@ -979,42 +910,17 @@ namespace Kav
             }
         }
 
-        private static IEnumerable<(T, Matrix)> FrustumCull<T>(
-            BoundingFrustum boundingFrustum,
-            IEnumerable<(T, Matrix)> cullableTransforms
-        ) where T : ICullable {
-            foreach (var (cullable, transform) in cullableTransforms)
-            {
-                var boundingBox = TransformedBoundingBox(cullable.BoundingBox, transform);
-                var containment = boundingFrustum.Contains(boundingBox);
-                if (containment != ContainmentType.Disjoint)
-                {
-                    yield return (cullable, transform);
-                }
-            }
-        }
-
-        private static bool FrustumCull<T>(
-            BoundingFrustum boundingFrustum,
-            T cullable,
-            Matrix transform
-        ) where T : ICullable {
-            var boundingBox = TransformedBoundingBox(cullable.BoundingBox, transform);
-            var containment = boundingFrustum.Contains(boundingBox);
-            return (containment == ContainmentType.Disjoint);
-        }
-
         private static IEnumerable<T> FrustumCull<T>(
             BoundingFrustum boundingFrustum,
-            IEnumerable<T> cullableTransformables
-        ) where T : ICullable, ITransformable {
-            foreach (var cullableTransformable in cullableTransformables)
+            IEnumerable<T> cullables
+        ) where T : ICullable {
+            foreach (var cullable in cullables)
             {
-                var boundingBox = TransformedBoundingBox(cullableTransformable.BoundingBox, cullableTransformable.TransformMatrix);
+                var boundingBox = TransformedBoundingBox(cullable.BoundingBox, cullable.TransformMatrix);
                 var containment = boundingFrustum.Contains(boundingBox);
                 if (containment != ContainmentType.Disjoint)
                 {
-                    yield return cullableTransformable;
+                    yield return cullable;
                 }
             }
         }

VertexDeclarations.cs

@@ -12,7 +12,7 @@ namespace Kav
         public static VertexDeclaration PositionTextureOffsetInstanceDeclaration = new VertexDeclaration
         (
             new VertexElement(0, VertexElementFormat.Vector3, VertexElementUsage.TextureCoordinate, 2),
-            new VertexElement(12, VertexElementFormat.Vector2, VertexElementUsage.TextureCoordinate, 5)
+            new VertexElement(12, VertexElementFormat.Vector4, VertexElementUsage.Tangent, 0)
         );
     }
 }

Vertices/PositionTextureOffsetInstanceVertex.cs

@@ -16,16 +16,16 @@ namespace Kav
         }
 
         public Vector3 Translation { get; set; }
-        public Vector2 UVOffset { get; set; }
+        public Vector4 UVData { get; set; }
 
         public static readonly VertexDeclaration VertexDeclaration;
 
         public PositionTextureOffsetInstanceVertex(
             Vector3 translation,
-            Vector2 uvOffset
+            Vector4 uvData
         ) {
             Translation = translation;
-            UVOffset = uvOffset;
+            UVData = uvData;
         }
     }
 }