From cfd52b00bd1e255ec1bf766b01d5ff81022194d0 Mon Sep 17 00:00:00 2001 From: cosmonaut Date: Thu, 8 Dec 2022 13:29:04 -0800 Subject: [PATCH] add FIXME note for spatial hash boxing --- src/Collision/Fixed/SpatialHash2D.cs | 1 + src/Collision/Float/SpatialHash2D.cs | 1 + 2 files changed, 2 insertions(+) diff --git a/src/Collision/Fixed/SpatialHash2D.cs b/src/Collision/Fixed/SpatialHash2D.cs index 7b7ceda..61d7951 100644 --- a/src/Collision/Fixed/SpatialHash2D.cs +++ b/src/Collision/Fixed/SpatialHash2D.cs @@ -12,6 +12,7 @@ namespace MoonWorks.Collision.Fixed private readonly Fix64 cellSize; private readonly Dictionary> hashDictionary = new Dictionary>(); + // FIXME: this ICollidable causes boxing which triggers garbage collection private readonly Dictionary IDLookup = new Dictionary(); public int MinX { get; private set; } = 0; diff --git a/src/Collision/Float/SpatialHash2D.cs b/src/Collision/Float/SpatialHash2D.cs index b015231..52bbd34 100644 --- a/src/Collision/Float/SpatialHash2D.cs +++ b/src/Collision/Float/SpatialHash2D.cs @@ -12,6 +12,7 @@ namespace MoonWorks.Collision.Float private readonly int cellSize; private readonly Dictionary> hashDictionary = new Dictionary>(); + // FIXME: this ICollidable causes boxing which triggers garbage collection private readonly Dictionary IDLookup = new Dictionary(); public int MinX { get; private set; } = 0;